Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve to_timestamp docs #8981

Merged
merged 3 commits into from
Jan 24, 2024

Conversation

Omega359
Copy link
Contributor

Updated documentation concerning to_timestamp scalar function including adding missing link in the datafusion-examples/README file.

Which issue does this PR close?

Closes #8980.

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

…ing adding missing link in the datafusion-examples/README file. Resolves apache#8980
Copy link
Contributor

@comphead comphead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice thanks @Omega359 , please take care on doc formatting task

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much @Omega359 -- looks great 👍

@@ -90,20 +92,47 @@ async fn main() -> Result<()> {
df.show().await?;

// use sql to convert a static string to a timestamp using a list of chrono formats to try
let df = ctx.sql("select to_timestamp('01-14-2023 01:01:30+05:30', '%+', '%d-%m-%Y %H/%M/%S', '%m-%d-%Y %H:%M:%S%#z')").await?;
// note that one of the formats is invalid ('%q') but since DataFusion will try all the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really nice -- thank you @Omega359

Copy link
Contributor

@comphead comphead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@alamb alamb merged commit d81c82d into apache:main Jan 24, 2024
23 checks passed
@alamb
Copy link
Contributor

alamb commented Jan 24, 2024

❤️ again for 📖 -- thanks @Omega359 and @comphead

@Omega359 Omega359 deleted the feature/8980_improve_to_timestamp_docs branch January 29, 2024 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve documentation for new to_timestamp functionality
3 participants